[LOPS-1661] Fix long tests #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespacebrian
approved these changes
Sep 13, 2023
| @@ -296,6 +296,7 @@ private function addBuiltInCommandsAndHooks() | |||
| { | |||
| // List of all hooks and commands. Update via 'composer update-class-lists' | |||
| $this->commands = [ | |||
| 'Consolidation\\Filter\\Hooks\\FilterHooks', | |||
There was a problem hiding this comment.
what's this do?
(i could try reading documentation but it's easier to just ask you)
There was a problem hiding this comment.
--filter to Terminus commands. It was removed by mistake in a previous PR and all of the commands tests that use that argument are failing now
| if (!empty($options['from_url']) && !empty($options['to_url'])) { | ||
| $params['wp_replace_siteurl']['from_url'] = $options['from_url']; | ||
| $params['wp_replace_siteurl']['to_url'] = $options['to_url']; | ||
| } |
There was a problem hiding this comment.
So, was it something about WP search-replace that was causing the long tests to fail?
There was a problem hiding this comment.
That was one of the failing tests, probably broken since it was created and never noticed.
There were other failing tests also fixed in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing now: https://github.com/pantheon-systems/terminus/actions/runs/6163052957